bhnuka / pe

0 stars 0 forks source link

findPerson cannot take in blank space #3

Open bhnuka opened 10 months ago

bhnuka commented 10 months ago

findPerson does not allow the user to enter a blank space as the name, despite the fact that a blank space is accepted as input for part of the name. As Alex Yu allows you to find name by "Yu", even though it is just a part of the name, a blank space " " should return names with blank spaces (i.e contacts where the person has more than just a first name). This is according to the remarks for name provided under field, where a name can contain spaces. As such, a blank space should be an acceptable input.

image.png

soc-se-bot commented 9 months ago

Team's Response

Bug #4845

Thank you for your bug report.

In the Note under the Usage section of the User Guide, we have stated that whitespaces at the start and end of fields are trimmed.

Bug4845.png

As KEYWORD are fields for the findPerson command, leading and trailing whitespaces in KEYWORD are also trimmed.

Therefore, having a KEYWORD consisting of only whitespaces is equivalent to having no KEYWORD at all.

As such, the findPerson command will show an error about an invalid command format, as no KEYWORD is provided.

Hence, we believe that the current behaviour of the findPerson command is correct.

Nevertheless, we acknowledge that the User Guide is too vague regarding the accepted format of KEYWORD. We should have included the fact that the KEYWORD cannot consist entirely of whitespaces.

We hope that you understand our decision. Thank you.

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]