search

bhofmei / jbplugin-screenshot

JBrowse plugin that adds button which uses phantomJS to take browser screenshot
Other
9 stars 3 forks source link

Removing track labels? #10

Open scottcain opened 7 years ago

scottcain commented 7 years ago

Hi Brigette,

What would be involved in removing the track labels? I saw in the code that you had at least some of the infrastructure that to do it. Is there something on the JBrowse side that is holding it up?

Thanks, Scott

bhofmei commented 7 years ago

I originally really wanted to remove track labels and thought it would be easy because there is the “HideTrackLabels” plugin. Turns out, that the plugin calls a javascript function since it shows labels when you scroll. Unlike all of the other configuration options, there is no JBrowse configuration setting for track labels so there’s no preexisting internal-JBrowse way to turn off the track labels. I thought about calling the function used by that plugin, but it would require having the plugin installed and I think it did weird things when actually taking the screenshot.

Since, the goal is a screenshot and the labels don’t need to be visible when scrolling, it should be simple enough to leverage CSS and use “display:none” for all of the track labels. Unfortunately that means adding an special handler for that configuration which isn’t elegant (and drives the software engineer in me crazy), but possible.

I’ll look into implementing this in the next few days.

On Mar 20, 2017, at 1:20 PM, Scott Cain notifications@github.com wrote:

Hi Brigette,

What would be involved in removing the track labels? I saw in the code that you had at least some of the infrastructure that to do it. Is there something on the JBrowse side that is holding it up?

Thanks, Scott

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bhofmei/jbplugin-screenshot/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/APWCOmByJn5Wba0HAfzqWzRUfa0YarGfks5rnrVrgaJpZM4Miv3F.

scottcain commented 7 years ago

Hi @bhofmei

I just found out that the master branch of JBrowse (which will become release soon, I'm told) will support a "tracklabels=0" option. I have the master branch running on one of my servers, so I'll look at the code you've written for passing around those options to see if I can add the tracklabels option too.

bhofmei commented 7 years ago

Oh that makes things a lot easier for me. I only use the current stable release of JBrowse. When the next release comes out, I’ll be able to include hiding the track labels easily since I have all the necessary infrastructure already there.

On Mar 23, 2017, at 3:23 PM, Scott Cain notifications@github.com wrote:

Hi @bhofmei https://github.com/bhofmei I just found out that the master branch of JBrowse (which will become release soon, I'm told) will support a "tracklabels=0" option. I have the master branch running on one of my servers, so I'll look at the code you've written for passing around those options to see if I can add the tracklabels option too.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bhofmei/jbplugin-screenshot/issues/10#issuecomment-288833094, or mute the thread https://github.com/notifications/unsubscribe-auth/APWCOmmoQTnZzGou0QCm2bgd_6zPwwrsks5rosatgaJpZM4Miv3F.

cmdcolin commented 6 years ago

the &tracklabels=0 now supported when HideTrackLabels plugin enabled

there was a bug where &nav=0 and &tracklabels=0 until recently but was fixed in 1.13.0