search

bhollis / maruku

A pure-Ruby Markdown-superset interpreter (Official Repo).
MIT License
500 stars 80 forks source link

Potential regression with italic-bold-italic #103

Closed lilith closed 11 years ago

lilith commented 11 years ago

*italic***bold***italic* should become <em>italic</em><strong>bold</strong><em>italic</em> as in Markuku 0.6.1:

http://johnmacfarlane.net/babelmark2/?normalize=1&text=*italic***bold***italic*

Not <em>italic<strong><em>bold</em></strong>italic</em>

bhollis commented 11 years ago

Hi @nathanaeljones,

That's definitely true. We have a "pending" test in span_spec.rb that covers this - unfortunately, fixing another bug (I can't remember which) caused this parsing to fail. It's pretty tough to solve both as I recall.

I'm not honestly sure what the "right" interpretation should really be, either - as your link shows, there's disagreement between the different implementations.

bhollis commented 11 years ago

I was incorrect - we have a similar (potentially same cause) test case in "pending". I'll add this one.

bhollis commented 11 years ago

Fixed in master.