search

bhollis / ng-http-rate-limiter

Rate limiting for Angular 1's $http service
MIT License
2 stars 0 forks source link

1.0.2 update will fail on IE 11 (and lower) #2

Open steve-tapley opened 7 years ago

steve-tapley commented 7 years ago

Hi, I saw that you removed the underscore version of the find function in favour of the Array.find function.

However, according to MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find

the find function is not support in any version of internet explorer. It might be worth considering adding underscore back again, or adding a polyfill.

Cheers, Steve

bhollis commented 7 years ago

I'd accept a PR that did the (relatively simple) work of relaxing find with a simple loop. My app doesn't support IE so I figured we were past that :-)

-Ben

On Jan 18, 2017, at 5:58 PM, Steve Tapley notifications@github.com wrote:

Hi, I saw that you removed the underscore version of the find function in favour of the Array.find function.

However, according to MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find

the find function is not support in any version of internet explorer. It might be worth considering adding underscore back again, or adding a polyfill.

Cheers, Steve

― You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.