validate arguments to ngettext

bholloway / react-i18n-interpolation

String interpolation of translated text and react components

MIT License

1 stars 2 forks source link

Closed bholloway closed 6 years ago

bholloway commented 6 years ago

Addresses #7 and #8.

Changes

Validate arguments to ngettext.
- Need 2 stages of validation, one for outer closure and another for the inner template.
- Reusable per assert.js, since we anticipate more API methods in the future.
- Additional tests
Streamline the error messages in both gettext and ngettext. Be more specific in the tests.

nkbt commented 6 years ago

Where is your CircleCI check?

bholloway commented 6 years ago

Currently there is a prepublish check but not CI integration. EDIT - actually good point in general because prepublish does not run test 🤕