search

bholloway / react-i18n-interpolation

String interpolation of translated text and react components
MIT License
1 stars 2 forks source link

tests #3

Closed bholloway closed 7 years ago

bholloway commented 7 years ago

Note that ngettext remains broken (WIP). I have commented it so that gettext passes tests clearly.

bholloway commented 7 years ago

With respect to tests...

The down-side of tape-bdd is that it expects only 1 assertion per it() statement. This forces me to make an array of multiple [expected, actual] tuples that I then deep compare in a single assertion.

Personally I think that jasmine is a lot clearer in terms of assertions. However it is bloatware in comparison and I hate the globals. I want to revisit this later, but more toward making tape work better for BDD.

bholloway commented 7 years ago

Any remaining issues should be minor, lets fix in the next PR