runfaj
commented
4 years ago If it helps, here's the original find-file that was doing the recursive search. https://github.com/bholloway/resolve-url-loader/blob/4d8df6d250ef870b70fdf125d041eaa95f597db1/lib/find-file.js
Though not as elegant, here's my join method currently to somewhat replicate the needed functionality. Could definitely be optimized like the original (in the link above) to filter out things above the root path and such.
function doResolveJoin(fileName, options) {
return function(uri, candidate) {
////skip data: type urls
if (_.includes(uri, 'data:')) {
return uri;
}
////if already absolute
if (path.isAbsolute(uri)) {
return uri;
}
////if already relative, convert to absolute
if (_.startsWith(fileName, '.')) {
return path.resolve(uri);
}
////else, search for matching module path by walking up tree
let pathsToTry = [];
//search fileName path first - better chance of matching
let pathParts = fileName.split('/');
pathParts.pop(); //remove actual file scss file reference, so it is path only
while (pathParts.length > 0) {
pathsToTry.push(pathParts.join('/'));
pathParts.pop();
}
//then try candidate path search
pathParts = candidate.split('/');
while (pathParts.length > 0) {
pathsToTry.push(pathParts.join('/'));
pathParts.pop();
}
//gathered potential path list, now just check until we find a match
while (pathsToTry.length > 0) {
let testPath = path.join(pathsToTry[0], uri);
if (fs.existsSync(testPath)) {
return testPath;
}
pathsToTry.shift();
}
////couldn't find any matches - must be a user typed error
return uri;
};
}
bholloway
MightyPork
We recently have started migrating from webpack 3 to 4, and included in that is upgrading this package from 2 to 3. In our setup, we have many scss files that reference image urls like so:
url('images/<image>').V2
This images reference is a resolved path that is aliased as
src/client/images. In version 2 of the resolve url loader, in the eachSplitOrGroup function, the absolute variable (absolute = uri && findFile(options).absolute(directory, uri, resolvedRoot)) used a findFile method where it appears to do a queued recursive search going up the file structure until it finds the file.In that findFile case, this worked well because it would eventually walk up the tree until it reaches
src/clientand it finds the appended pathsrc/client/imagesand ultimately finds the absolute path the the filesrc/client/images/<image>.After that path is found, the following code runs and has the appropriate replacement with the relative path from the original file to the found absolute path.
V3
However, in V3, this isn't the case. The absolute variable mentioned above is now replaced by running the join method:
absolute = testIsRelative(uri) && join(uri, candidate) || testIsAbsolute(uri) && join(uri). This join method, instead of returning the appropriate path tosrc/client/images/<image>, just resolves to<sourceFilePath>/images/<image>. This is a result of the default join using asimpleJoinwhich just concats the paths together.Fix
Now, I'm sure I can rewrite the join method to meet my needs, but it seems like that behavior that existed in v2 should be re-added as a default instead of the "simpleJoin" method.
If not, at least the documentation should specify what this join method does, what the outputs will default to, and an example of how to write a custom one. It should also specify this as a breaking change, as it indeed does break just about every one of our scss files that use the existing V2 logic.