search

bholloway / resolve-url-loader

Webpack loader that resolves relative paths in url() statements based on the original source file
563 stars 71 forks source link

use version ranges to reduce package duplication #151

Closed spalger closed 3 years ago

spalger commented 4 years ago

Fixes https://github.com/bholloway/resolve-url-loader/issues/150

I work on a project with several hundred direct dependencies and when looking to add resolve-url-loader I noticed it was installing several packages that we already have installed because strict versions are used for direct dependencies. It's generally ideal to use version ranges unless they don't work for some reason, but the tests all pass with these new versions installed, so hopefully you don't mind this change.

TrySound commented 3 years ago

Friendly ping @bholloway in case you don't get notifications.

spalger commented 3 years ago

Thanks @bholloway, you got it.

bholloway commented 3 years ago

Sorry @spalger conflicts again. @TrySound has removed compose-function.

Could you please rebase again and force push.

AFAIK resetting the yarn lock to what it originally is on the base branch and then doing an install should give you minimum changes. If you could try that please or otherwise satisfy yourself the lock is minimally changed. Thx.

EDIT - Since we have several small PRs and they are merging quickly please post a comment when you start your rebase. That way I can block other merges while you are working and avoid further conflicts.

spalger commented 3 years ago

Alright, working on the rebase now

spalger commented 3 years ago

Alright, should be good