search

bholloway / resolve-url-loader

Webpack loader that resolves relative paths in url() statements based on the original source file
563 stars 71 forks source link

add warning if no source-map found #155

Closed robertg042 closed 3 years ago

robertg042 commented 4 years ago

This warning can help diagnose problems with downstream path errors if no source-path is generated upstream.

bholloway commented 3 years ago

Sorry for the delay @robertg042. This seems like a good idea.

I've changed PR target to v4-development where the active development is.

Unfortunately the test suite is annoying to run so I don't expect you to do that. I will try to get a test case ready so we can merge this.

robertg042 commented 3 years ago

Hey @bholloway, I've changed the warning's description to the one you've proposed. Frankly, couldn't think of anything better :)

Unfortunately the test suite is annoying to run so I don't expect you to do that. I will try to get a test case ready so we can merge this. I appreciate that. I remember trying to get my head around it but failed. It's also my very first, albeit small, contribution to any open-source project, so please bear with my lack of know-how.

bholloway commented 3 years ago

Thanks for the contribution @robertg042 👍