search

bholloway / resolve-url-loader

Webpack loader that resolves relative paths in url() statements based on the original source file
563 stars 71 forks source link

Improve docs #188

Closed bholloway closed 3 years ago

bholloway commented 3 years ago

Primarily we are reviewing this new document here.

There are some changes to the v4 join function as a result of writing the "how to" examples.

The detail of the code changes under the hood don't matter as much as the API and docs to use it.

Tests

MightyPork commented 3 years ago

I'll try to give you some feedback next week, if I manage to convince npm to install this unreleased version. I'm still using my joinHack with 4.0.0-alpha.1, it's still the same ugly, but works fine.

bholloway commented 3 years ago

I'll try to give you some feedback next week, if I manage to convince npm to install this unreleased version.

Okay I'll merge this PR when ready and release a new alpha. That will make it easier to install. Let's to defer this until then. 👍

bholloway commented 3 years ago

This is published as resolve-url-loader@4.0.0-alpha.3.

@MightyPork lets continue the conversation back in #129