Closed kroko closed 8 years ago
Thanks for PR.
I'm about 1000km away from a computer right now. But expect something next week.
Dear @kroko. In general I think this is pretty safe and I'm happy merge if it tests ok on your use case.
I value your PR so rather than writing myself I would want to merge your PR and give you credit for contributing.
However I have made some inline comments you might consider. If you have strong contrary opinion then just let me know. I will then test any final code on my code-base with the option turned off.
Sure, will look into your comments this weekend and change things according to them. Thanks!
Ok looks good.
I will test backwards compatibility with a couple of projects. Can you just confirm the latest code works for your use case.
Latest code works with our use case.
Ok @kroko thats published as 1.5.0
.
Pleasure working with you. Let me know if there are any problems.
Currently resolve-url-loader strips off all query strings for CSS URLs. There is a reason why coder would add query or hash to the end of URL, we should keep it.
For example. This is undesirable (meaning breaking :) ) when url is eot font with dummy query that is needed for IE. Sure, it is IE8, however we still want to get "update your browser" message using nice typeface. And Webpack is not only for top edge, you can pack ES3 apps with it :)
Consider
So option to pass
keepQueryInUrl
is added, which I left to be false by default, so nobody that relies on the current behaviour would suffer.css-loader
and eventuallywebpack
core down the road does not care about it, it just works. and both whenrelative
(default) orabsolute
option is passed to resolve-url-loader.Please revise. If all OK, please merge and bump npm package.
Regards, kroko