search

bholloway / resolve-url-loader

Webpack loader that resolves relative paths in url() statements based on the original source file
563 stars 70 forks source link

Fix deprecation warning from loader-utils #47

Closed cheeaun closed 7 years ago

cheeaun commented 7 years ago

Been getting this:

DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56

Reference: https://github.com/webpack/loader-utils/issues/56

bholloway commented 7 years ago

This looks pretty easy @cheeaun, thanks for bringing to my attention.

bholloway commented 7 years ago

I have released a 2.0.1 patch.

Please confirm this fixes the issue and we can close.

cheeaun commented 7 years ago

Thanks! I've tried the patch and seems to be working fine so far. I'm mainly getting the deprecation warning from other loader dependencies now.

I did some extra checks and there is one more thing; resolve-url-loader has a dependency on adjust-sourcemap-loader which uses the older version of loader-utils, so... yeah 😃

bholloway commented 7 years ago

Good luck with adjust-sourcemap-loader, I hear the package owner is a real pain!

Seriously though, sorry I didn't think of that. Let me see what I can do.

cheeaun commented 7 years ago

^ Created an issue there to make it easy for keeping track 😃

bholloway commented 7 years ago

Please try 2.0.2 which has the new adjust-sourcemap-loader.

The only Webpack 2 project that is close to hand is sass-loader/example/... and for some reason it does not give this deprecation warning. So I hope this just fixes the problem.

cheeaun commented 7 years ago

Seems good so far! Thanks a lot! 👍

bholloway commented 7 years ago

Cool. I will close the issue optimistically.

Let me know any problems thought.