bholloway / resolve-url-loader

Webpack loader that resolves relative paths in url() statements based on the original source file
563 stars 71 forks source link

Possible fix for #79 #80

Closed acoll closed 6 years ago

acoll commented 6 years ago

Issue #79

I just added a simple truthy check to prevent the error. I'm not sure this is the right fix or not.

circlingthesun commented 6 years ago

Works for me :+1:

circlingthesun commented 6 years ago

Works on both Webpack 3.5.0 and 4.0.0 for me.

sentilesdal commented 6 years ago

Worked for me too!

KnisterPeter commented 6 years ago

@bholloway Works fine. this.options is just not set for webpack 4 anymore

bholloway commented 6 years ago

@acoll Don't panic if you see "closed" on the PR, I merged this correctly via the git command line per the github instructions.

acoll commented 6 years ago

👍 sounds good. Thanks for fixing that.