search

bhoov / manim-notebook

Simple commands to replicate the manim dev workflow in VSCode
MIT License
5 stars 2 forks source link

Use already open Manim interactive shell #24

Open Splines opened 6 hours ago

Splines commented 6 hours ago

If there is any terminal already opened that has Manim running in IPython, we should use that terminal. With this detection logic, we could also error if users use the Quit Preview command when they don't have any Manim session open. Other commands could also profit from this behavior.

If multiple Manim scenes are opened, e.g. two terminals with running IPython Manim session, then use the terminal that is visible to the user. If both are visible, use the one that has the current focus. If none has the current focus, use the one that had the focus the most recently.

Also see this comment and the last section of my comment here.

VladimirFokow commented 5 hours ago

with this detecting logic - we can also have a HUGE usability improvement for new users:

to get started - they will just need to click "Preview Manim Cell" -> we can have detection and if we detect that their manimgl isn't running - we start it (at the start of the scene), and only then run the cell.

Is this method helpful? - https://github.com/bhoov/manim-notebook/issues/25#issuecomment-2436082713

This would move us closer to the terminal-free workflow

bhoov commented 3 minutes ago

This would be an awesome feature, I agree about the usability improvement. I'm going through and labeling features for a v0.1.0 release. My goal is to have it on the marketplace by end of the weekend so we can announce on twitter/where you all like early next week. Do you all think this is a priority to integrate for v0.1.0?