search

bhoov / manim-notebook

Simple commands to replicate the manim dev workflow in VSCode
MIT License
5 stars 2 forks source link

Detect errors in Manim startup command #34

Open Splines opened 4 hours ago

Splines commented 4 hours ago

With the code from #33, the Starting Manim... command is currently run indefinitely when an error occurs in the Python terminal. I think we should definitely tackle this before the release to avoid frustrated users, e.g. when they don't already have Manim installed and click on Preview Manim Cell. Or when any other error occurs during the startup. Otherwise, we end up with an indefinite, non-cancellable notification.

image

Additionally, we could just open the terminal in this case, such that users directly see the error message if they didn't have the terminal opened beforehand.

Splines commented 4 hours ago

I can tackle this once the current PRs until #33 are reviewed and merged.