bhrigu123 / Instant-Lyrics

Shows lyrics of the currently playing Spotify song, or any song, instantly.
http://bhrigu.me/Instant-Lyrics/
195 stars 33 forks source link

Please provide an AppImage for Linux #3

Open probonopd opened 7 years ago

probonopd commented 7 years ago

Currently it is quite complicated to install Instant-Lyrics, with many manual steps:

install

Providing an AppImage would have, among others, these advantages:

Here is an overview of projects that are already distributing upstream-provided, official AppImages.

I generated a test AppImage for Instant-Lyrics: https://bintray.com/probono/AppImages/Instant_Lyrics/_latestVersion#files Just download, make it executable, and run. Should work on most 2014-ish and later distributions. Some fine-tuning may be needed.

Here is a yml file that controls the AppImage generation: https://github.com/probonopd/AppImages/blob/master/recipes/meta/Instant-Lyrics.yml

To run it, do the following on a Ubuntu or Debian system:

wget https://github.com/probonopd/AppImages/raw/master/recipes/meta/Recipe
bash -ex Recipe Instant-Lyrics

This will grab the latest version of Instant-Lyrics from this GitHub repository and produce an AppImage.

probonopd commented 7 years ago

Such a relief to see this button now:

screenshot from 2017-03-22 00-07-28

So, would you like to provide an official one?

bhrigu123 commented 7 years ago

Hi, I just tested out the AppImage on my computer, and it's working fine. I just had a few questions/clarifications:

  1. To create an AppImage in the future, I would need to run the command bash -ex Recipe Instant-Lyrics, which I guess will do the following:
  1. It is not showing the icon when it adds Instant Lyrics to desktop apps entry. appimage
probonopd commented 7 years ago

Can you please point me to a 256x256 px application icon in your repository that we can put into ./usr/share/icons/hicolor/256x256/apps/instantlyrics.png?

bhrigu123 commented 7 years ago

ah! I hadn't maintained the icons properly. Hold up; I'll need to add some more resolutions icons. I'll let you know.

bhrigu123 commented 7 years ago

Added the 256x256 png at https://github.com/bhrigu123/Instant-Lyrics/blob/master/icons/instant-lyrics-256.png

probonopd commented 7 years ago

Updated https://github.com/probonopd/AppImages/blob/master/recipes/meta/Instant-Lyrics.yml

bhrigu123 commented 7 years ago

Great.

So, just to confirm, to create a new AppImage, I just need to run bash -ex Recipe Instant-Lyrics, which will automatically fetch the latest master branch of my repo. (which I should add to my releases). right?

probonopd commented 7 years ago

That is correct @bhrigu123. Alternatively you can of course host your own yml and feed that into the Recipe.

bhrigu123 commented 7 years ago

Oh cool.

I'm finishing up on some changes and will update the repo soon.

bhrigu123 commented 7 years ago

Done.

probonopd commented 7 years ago

Works like a charm for me. Thank you for this useful app!

bhrigu123 commented 7 years ago

Hey, @probonopd , the AppImage stopped working suddenly. When I tried running it from the terminal I'm now getting this error:

./Instant_Lyrics-git.e3c0cc2.glibc2.15-x86_64.AppImage 
/bin/bash: ../lib/x86_64-linux-gnu/libtinfo.so.5: no version information available (required by /bin/bash)
Traceback (most recent call last):
  File "/tmp/.mount_kGRBO8/usr/bin/instantlyrics", line 2, in <module>
    import gi
  File "/usr/lib/python2.7/dist-packages/gi/__init__.py", line 42, in <module>
    from . import _gi
ImportError: /usr/lib/python2.7/dist-packages/gi/_gi.x86_64-linux-gnu.so: undefined symbol: g_irepository_get_immediate_dependencies

(I have created it using the yml file only that you provided )

probonopd commented 7 years ago
  File "/usr/lib/python2.7/dist-packages/gi/__init__.py", line 42, in <module>
    from . import _gi
ImportError: /usr/lib/python2.7/dist-packages/gi/_gi.x86_64-linux-gnu.so: undefined symbol: g_irepository_get_immediate_dependencies

suggests that files are being loaded from /usr rather than from inside the AppImage. Need to find out the reason for this and change it.

probonopd commented 7 years ago

Could this change be the culprit? https://github.com/probonopd/AppImages/commit/020e0a3eaaea3db337a48628b8ebd347206b188a

bhrigu123 commented 7 years ago

um...I can't be much sure about the Recipe file.

Although, how can an AppImage, which was running fine previously, would suddenly stop working? I mean that AppImage file has already been bundled/compiled. And no changes can be done to it now. So how can that same file stop to work like before?

probonopd commented 7 years ago

So, you are saying you did not make or download a new AppImage, but the existing one suddenly stopped working?

In this case, something on your system must have changed, since AppImages are immutable (=read-only).

bhrigu123 commented 7 years ago

Yes, that is correct. The existing AppImage stopped working. I don't think I did anything that could cause changes to my system.

Also, when I'm running my app directly from source (the python file) then it is working just fine. So if it can run from the Python file, I think the system must be fine.

probonopd commented 7 years ago

The one on your GitHub Releases page works fine for me on KDE neon User Edition 5.9:

screenshot_20170326_183626

bhrigu123 commented 7 years ago

Oh, okay. The same file is not running on mine. Not sure why. Let me just see if it is working on some more systems also, or is it just me.

kareemamrr commented 7 years ago

What is the command for Fedora25? Please help.

bhrigu123 commented 7 years ago

@kareemamrr1203 Are you trying to install from AppImage or from Source? At the moment, the AppImage is of older version. To get latest version, install from source.

If you are installing from AppImage:

To install and run from source, instructions are given in README.

kareemamrr commented 7 years ago

I followed the instructions but at the last step it just does nothing, thoughts? screenshot-20170404174811-734x490

bhrigu123 commented 7 years ago

Yes it will not display any message on the terminal. After running the command, there should be a new icon appearing on the Indicator Panel (System Tray). See if it's there.

(Also, create a New issue if there's still problem. This issue was for AppImage)

kareemamrr commented 7 years ago

i'm sorry I don't know how im new here :D but no icon is appearing on the tray still screenshot-20170404175631-267x127

bhrigu123 commented 7 years ago

Oh....I see. I've not tested on Fedora yet, and am not much a Fedora guy.

Are there some different Sessions/Display Supports in Fedora. Like Wayland, X11 or Xorg. Try running on a different Session. Because someone else also had an issue. See this: #4

I'll soon test on Fedora and see to it.

probonopd commented 7 years ago

@kareemamrr1203 did the AppImage work for you?

probonopd commented 6 years ago

Ping - how do you want to proceed with this?