Make Instant-Lyrics app-agnostic - Githubissues

bhrigu123 / Instant-Lyrics

Shows lyrics of the currently playing Spotify song, or any song, instantly.

http://bhrigu.me/Instant-Lyrics/

195 stars 33 forks source link

Make Instant-Lyrics app-agnostic #5

Open nicolas-guichard opened 7 years ago

nicolas-guichard commented 7 years ago

Why restrict to Spotify lyrics? Instant-Lyrics is already using MPRIS, so it can be aware of music apps running. This is what my changes do:

Instant-Lyrics can now list running music apps and update the AppIndicator accordingly
It will do so upon each DBus event related to music apps (I couldn't figure a way to reliably rebuild the menu upon opening, it may list closed apps until following DBus event)

I also corrected an encoding problem with accents.

This shows a summary of the changes: capture du 2017-04-01 17-40-52

bhrigu123 commented 7 years ago

allow me some time on this.

simonbru commented 6 years ago

This feature works well on my side after the fix I mentioned above. One minor issue: the app list does not update right away after closing a media player. However it will get updated after any other action triggering a signal from /org/mpris/MediaPlayer2 so this is probably good enough.