[Android Bootcamp] Assignment 2 - Instagram Photo Viewer ready for review

[bhsat]

My app is complete, please review - /cc @codepathreview @codepath

• Bhavani Satyanath

[codepathreview]

Great work finishing the stories. Here is some feedback after reviewing your code --

• Initializing Fresco should be done in Application's onCreate method
• A good practice will be to refactor Activity's onCreate method into helper methods such as initUi(). This keeps lifecycle methods clean and increases readability, specially as your Activity increases in complexity
• It's preferred that a convenience method be created on the adapter to reload content. This helps DRY up code and encapsulate adapter behavior if the Activity needs to call this several times in different places.
• You should be retrieving context from view holder or the parent view in RecyclerView.Adapter subclasses
• Good job setting OnClickListener instances in ViewHolder constructor rather than RecyclerView.Adapter.onBindViewHolder(),
• Good job setting up InstagramClient such that every endpoint is represented with a method which then accepts specific parameters and a “handler”. You should pass down url also to the methods.
• Good job handling the network error case by overriding onFailure and notifying the user via a Toast that the network request failed.