search

bhubr / react-simple-oauth2-login

Simple React component for OAuth2 login - Supports Authorization Code and Implicit Grant flows.
MIT License
49 stars 31 forks source link

Increase popup height #23

Closed tennox closed 3 years ago

tennox commented 3 years ago

The OAuth UI is always bigger than the modal:

Screenshot from 2021-06-15 17-39-30

bhubr commented 3 years ago

I have a few pending PRs including this one, I'll look at them all when I come back from holiday tomorrow!

Le mar. 15 juin 2021 à 17:41, Manuel @.***> a écrit :

The OAuth UI is always bigger than the modal:

[image: Screenshot from 2021-06-15 17-39-30] https://user-images.githubusercontent.com/2084639/122083030-cd9ef280-ce00-11eb-8a5e-7bbb56449be0.png

You can view, comment on, or merge this pull request online at:

https://github.com/bhubr/react-simple-oauth2-login/pull/23 Commit Summary

  • Increase popup height

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bhubr/react-simple-oauth2-login/pull/23, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUQBNW56UYXKKL2WR5KBRDTS5YBBANCNFSM46XRHVQA .

bhubr commented 3 years ago

@all-contributors please add @tennox for code

allcontributors[bot] commented 3 years ago

@bhubr

I've updated the pull request to add @tennox! :tada:

bhubr commented 3 years ago

@tennox I merged your PR, but there was another tackling the same issue: #26 which I merged too.

I finally reverted the default popup height to a "middle ground" (680px) since on some screens (e.g. my 2018 MacBook pro), 800px is more than a full-size browser window's height.

tennox commented 3 years ago

@bhubr Great, thanks! :)