search

bhubr / react-simple-oauth2-login

Simple React component for OAuth2 login - Supports Authorization Code and Implicit Grant flows.
MIT License
49 stars 31 forks source link

feat: add extra params prop to ferry to auth url query params #40

Closed jshthornton closed 3 years ago

jshthornton commented 3 years ago

Some oauth providers allow for additional query params that change their popup behaviour. For example Google allows a prompt=consent query param that forces the user to have to choose the google account with each popup to cover case where the user has logged out of your site but not Google.

Fixes: #39

bhubr commented 3 years ago

Hey @jshthornton

Sorry for not chiming in earlier. It's been weird & busy times on my side 😅.

Thanks for the PR. I see no reason for not merging it. I'll add this prop to the relevant section in the README (unless you're willing to do so).

bhubr commented 3 years ago

@jshthornton I merged it in a feature branch.

I'm gonna add this to the README right away, update the version in package.json, merge to master, and publish the updated version right away.

Thanks again!