search

bhuga / hackable-slack-client

Inject CSS or JS into Slack, per-team.
The Unlicense
111 stars 8 forks source link

Slacks hack loader does not seem to run? #19

Open jbreckmckye opened 7 years ago

jbreckmckye commented 7 years ago

I'm not able to change the theme using the instructions in the README.

In my profile, I changed my title field to haxs://slacks-hacks.herokuapp.com/assets/application.css, but to no avail. This file appears to be available over the open internet and should set my interface to use Helvetica as a font, amongst other changes. This doesn't happen though.

Reading the slack-hacks-loader.js script, I'm expecting the console to output Slack hacks loader loading.... But pulling up the console in the process shows no such message.

bhuga commented 7 years ago

But pulling up the console in the process shows no such message.

I'd expect to see some sort of output as well. Are you pulling up the console for the main window (which contains several slacks) or one slack's webframe?

To ensure you're using the particular slack's webframe, right-click on the Slack team and select Inspect Element (and not Inspect Parent Element). There should be a ton of output there; Slack usually throws a lot of warnings on its own.

jbreckmckye commented 7 years ago

Err... I didn't realize I'd posted this. I found the aforementioned message in one of the slack frames, as mentioned, and decided to abandon the post. It still wasn't clear why the resources wouldn't load, though - I wasn't able to trigger breakpoints within the asset loader.

bhuga commented 7 years ago

Do you have a #slack-hacks channel with a 'purpose' defined? I realize I don't personally use a profile field without the channel, and have considered the profile field a backup. I thus haven't tested your situation explicitly and it could be broken.

jbreckmckye commented 7 years ago

Oh, no, I don't have a channel set up. I interpreted the docs to suggest I didn't need one. I will give that a try tomorrow.

bhuga commented 7 years ago

Oh, no, I don't have a channel set up. I interpreted the docs to suggest I didn't need one. I will give that a try tomorrow.

It shouldn't be required, but I'm not testing it 😊, and we all know untested code paths are just the best. If that fixes it for you, let me know and I'll take a stab at fixing it properly.