Closed wpoely86 closed 10 years ago
I can confirm that this patch fixes the vacation plugin for roundcubemail version 0.9.5 on Centos 6. I've switched to wpoely86's repository until this patch gets pulled in bhuisgen's repo.
Thanks for your patch wpoely86 !
This fix solves calender problem, unfortunately for me (Debian Wheezy) it caused errors in roundcube log.
"PHP Fatal error: Call to undefined method rcmail_output_json::add_script() "
I fixed this with adding "add_script" function in "roundcube/program/include/rcmail_output_json.php" file, which is not a really good solution. Please let me know if is there a better fix.
// add_script function
public function add_script($script, $position='head')
{
if (!isset($this->scripts[$position])) {
$this->scripts[$position] = "\n" . rtrim($script);
}
else {
$this->scripts[$position] .= "\n" . rtrim($script);
}
}
@xtavras yes, I fixed that but forgot to push it. I've added the fix to this PR. You need to check for HTML output before using the 'add_script' function.
I'm currently using this on rc-1.0 without problems.
@bhuisgen Are you still maintaining this plugin? If not, do you mind to let somebody take over?
Yes, it works for me on RC-1.0.1, thank you!
The way the calendar format string was added to the js of the page didn't work anymore with rc-0.9. I've changed the method and now it works again for me.