bhushan354 / Catalog-Of-Things

In this project ,me and my coding partners have created a console app that will keep record of different types of things user own : books, music albums, movies, and games. Database is based on the UML class diagram. The data is stored in JSON files but we have also prepared a database with tables structure analogical to programmes classes
MIT License
0 stars 1 forks source link

Setup-Kanban-Board #28

Open bhushan354 opened 10 months ago

bhushan354 commented 10 months ago

GitHub project link: https://github.com/bhushan354/Ruby-Group-Capstone/projects/1

Overall, 3 people in a team: Team member #1 https://github.com/bhushan354 Team member #2 https://github.com/Ochiengsteven Team member #3 https://github.com/sagieramos

Thank you.

mukhammadrizooff commented 10 months ago

Hi @TEAM,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Required Changes ♻️

image

image

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Shedrack-Sunday commented 10 months ago

Hi @bhushan354 @sagieramos @Ochiengsteven 👍

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

image

Highlights

Optional suggestions Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.