search

bhushan354 / Receipe-App

Recipe App is a web application built using Ruby on Rails that allows users to create and manage recipes, track their ingredients, and generate shopping lists.
MIT License
0 stars 0 forks source link

Kanban Board Review #17

Open bhushan354 opened 7 months ago

bhushan354 commented 7 months ago

Hello Reviewer , We are team of two coding partners @malikhaiderkhan and @bhushan354 .

Here's link to our kanban board : https://github.com/users/bhushan354/projects/5

Thank you , Malik and Bhushan .

zeff96 commented 7 months ago

Status: CHANGES REQUIRED ♻️

Hi @bhushan354 and @malikhaiderkhan ,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

almost

Highlights

:heavy_check_mark: Fair work distribution

Required Changes ♻️

in your implementation, you only have three columns, kindly consider adding all the required columns image

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

thecodechaser commented 7 months ago

STATUS: APPROVED 🟢

Hi @bhushan354, and @malikhaiderkhan👋,

Your project is complete! There is nothing else to say other than... it's time to close it :shipit: Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.