search

bhushankummar / amazon-mws

Amazon MWS NodeJS Wrapper
MIT License
197 stars 78 forks source link

Development #99

Closed bhushankummar closed 4 years ago

bhushankummar commented 5 years ago

@beastmike1 @wangjue666 @sottenad Your PR is merged here. Can you please validate once so I can release a new version?

bhushankummar commented 4 years ago

@tylerreece22 Can you confirm, after merge all features working perfectly?

@beastmike1 @wangjue666 @sottenad Can you please validate once so I can release a new version?

Your inputs will highly be appreciated.

tylerreece22 commented 4 years ago

@bhushankumarl I can check submitFeed, feedResult, and resultList. Those are really the only ones I am familiar with for my project. Also, when will this branch be merged? I have a time constraint.

tylerreece22 commented 4 years ago

@bhushankumarl submitFeed, feedResult, and resultList all work as expected with my change.

jesusvalle commented 4 years ago

@bhushankumarl @beastmike1 Hi, I have tested the STREAM function with a big data file of orders and listings reports and it works perfectly.

I would recommend to add to the documentation something to make people use that method from the beginning so they don't have to remake all their code as it happened to us.

tylerreece22 commented 4 years ago

@bhushankumarl can we get this PR merged? I would prefer to use this library for my project but without the bug fix I provided this module wont work.

beastmike1 commented 4 years ago

@bhushankumarl Hi I have have tested the STREAM fucntion and all is working fine

tylerreece22 commented 4 years ago

@bhushankumarl it seems the code has been tested. Can you please merge?

sottenad commented 4 years ago

@bhushankumarl - I have tested/reviewed the development branch after these PR's and my change is looking fine! +1 to merge to master.

tylerreece22 commented 4 years ago

Cricket cricket 🦗

bhushankummar commented 4 years ago

@tylerreece22 @jesusvalle @beastmike1 @sottenad Thank you all. The new version has been released. https://github.com/bhushankumarl/amazon-mws/releases/tag/v0.0.25 https://www.npmjs.com/package/amazon-mws

tylerreece22 commented 4 years ago

@bhushankumarl yay! thanks!