search

bhuvnesh123 / FFmpeg-Video-Editor-Android

Sample android project using ffmpeg for cutting and compressing video,reversing video,extracting image frames from video,extracting audio from video,add fade in fade out effect,create fast and slow motion video
540 stars 165 forks source link

License #12

Open brarcher opened 6 years ago

brarcher commented 6 years ago

You do not mention a license for your code, either in a LICENSE file or in a comment block in the java source files. On your wordpress site you answer the question:

Can i use this in a commercial android app? Will there be any license issue?

with the following:

Yes,you can use it in a commercial app.Please go through this- https://video.stackexchange.com/questions/14802/can-i-use-ffmpeg-in-a-commercial-product/14804#14804 and https://github.com/WritingMinds/ffmpeg-android/blob/master/LICENSE.GPLv3

Is your code also under GPLv3 (which would be problematic for commercial uses), or is it public domain but you are warning that a dependency is GPLv3? Or, would you be interested in adopting a license which is permissive, such as MIT or Apache 2?

bhuvnesh123 commented 6 years ago

My code is basically a sample project and can be used publicly but the dependency I have used has a license.

brarcher commented 6 years ago

It is OK that your project is a sample project. However, I am interested in using some parts of it or looking through it for examples to create a different open source project. (: I'll only be able to do so if I clearly understand what license you code is released under.

Are you saying that the project is public domain? If this is so, would you mind adopting the following license (or an equivalent)? Adding a LICENSE file to the top level of the repo will help make it clear to anyone else who may come upon your code.

Thanks!

hopewise commented 6 years ago

If this project depends on GPL licensed dependencies, then its considered to be licensed under the GPL terms.

brarcher commented 6 years ago

FFfmpeg is distributed as a binary instead of being linked into the application. In this case, the GPL license in the FFmpeg binary does not cause the java code to be GPL.

Instead, the project is using an Apache licensed components, which would not result in the code needing to use the Apache license.

I think the author is not obligated to use GPL.

hopewise commented 6 years ago

ah, so if a GPL based library is used as binary then the source code of the project is not affected?

brarcher commented 6 years ago

If an application links against GPL code the application needs to be GPL. However, if an application forks/exec a GPL stand-alone binary is there no requirement for the application to be GPL.

Another example of this is Busybox with is GPLv2. If an embedded device uses Busybox utilities it does not mean that all source code in the embedded device which fork/exec the utilities must be GPLv2. However, if an application directly links against Busybox or uses it source code then it would have the requirement.

In the case of this video editor, FFmpeg is being used as a stand-alone binary, so the GPL license does not affect the Java source code. There are ways to link libraries into the JVM (e.g. with JNI) that would cause the license to take affect, but that is not being done here.

niccokunzmann commented 4 years ago

@bhuvnesh123, I would be happy, if you just add a license file. This app seems quite nice and the code is visible, so having a license file explains that it can be used and in which ways.

niccokunzmann commented 4 years ago

The code is much too complex to be just an example project. It is like illegal to use in Germany at least. A license grants other the ability to use it as such. You can take for example the MIT license: Create a new file using the GitHub web site, name it "LICENSE" and choose from those which GitHub suggests.

Xheghun commented 4 years ago

There's nothing complex about this project

On Sun, 24 Nov 2019, 8:34 pm Nicco Kunzmann, notifications@github.com wrote:

The code is much too complex to be just an example project. It is like illegal to use in Germany at least. A license grants other the ability to use it as such. You can take for example the MIT license: Create a new file using the GitHub web site, name it "LICENSE" and choose from those which GitHub suggests.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bhuvnesh123/FFmpeg-Video-Editor-Android/issues/12?email_source=notifications&email_token=AHSLEROUN6ODBOLFPAXGBMLQVLJLDA5CNFSM4EKCM7I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFATADA#issuecomment-557920268, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHSLERODQOCC4FYCY44AZTTQVLJLDANCNFSM4EKCM7IQ .

niccokunzmann commented 4 years ago

Thanks for stating this again. This might be the case for you. If you invested more that 1 hour into this project, this argumentation does not hold in court. As such, I will not base my work on it. That is ok for me, though. Why I am writing this is to let you know that you saying it is simple does not mean that non-technical law-people from other countries agree to it. I value the project and I see this as my part of contribution. I am also willing to not write if you do not like to read this.

On 11/25/19 8:13 AM, Rhufhai Xheghun wrote:

There's nothing complex about this project

On Sun, 24 Nov 2019, 8:34 pm Nicco Kunzmann, notifications@github.com wrote:

The code is much too complex to be just an example project. It is like illegal to use in Germany at least. A license grants other the ability to use it as such. You can take for example the MIT license: Create a new file using the GitHub web site, name it "LICENSE" and choose from those which GitHub suggests.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub

https://github.com/bhuvnesh123/FFmpeg-Video-Editor-Android/issues/12?email_source=notifications&email_token=AHSLEROUN6ODBOLFPAXGBMLQVLJLDA5CNFSM4EKCM7I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFATADA#issuecomment-557920268, or unsubscribe

https://github.com/notifications/unsubscribe-auth/AHSLERODQOCC4FYCY44AZTTQVLJLDANCNFSM4EKCM7IQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bhuvnesh123/FFmpeg-Video-Editor-Android/issues/12?email_source=notifications&email_token=AAEJ4IGSR2WMWAZVXJGCIRLQVN3KVA5CNFSM4EKCM7I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFBMBZY#issuecomment-558022887, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEJ4ICDCMXGFXQ4PEYKWPLQVN3KVANCNFSM4EKCM7IQ.

Xheghun commented 4 years ago

You're free you to write and contribute to this open source project, what I'm trying to say is ffmpeg is a powerful command line tool for video and audio manipulation and most of the features in the app are implemented with a simple ffmpeg command, ffmpeg itself has its license.

On Mon, 25 Nov 2019, 10:25 am Nicco Kunzmann, notifications@github.com wrote:

Thanks for stating this again. This might be the case for you. If you invested more that 1 hour into this project, this argumentation does not hold in court. As such, I will not base my work on it. That is ok for me, though. Why I am writing this is to let you know that you saying it is simple does not mean that non-technical law-people from other countries agree to it. I value the project and I see this as my part of contribution. I am also willing to not write if you do not like to read this.

On 11/25/19 8:13 AM, Rhufhai Xheghun wrote:

There's nothing complex about this project

On Sun, 24 Nov 2019, 8:34 pm Nicco Kunzmann, notifications@github.com wrote:

The code is much too complex to be just an example project. It is like illegal to use in Germany at least. A license grants other the ability to use it as such. You can take for example the MIT license: Create a new file using the GitHub web site, name it "LICENSE" and choose from those which GitHub suggests.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub

< https://github.com/bhuvnesh123/FFmpeg-Video-Editor-Android/issues/12?email_source=notifications&email_token=AHSLEROUN6ODBOLFPAXGBMLQVLJLDA5CNFSM4EKCM7I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFATADA#issuecomment-557920268 , or unsubscribe

< https://github.com/notifications/unsubscribe-auth/AHSLERODQOCC4FYCY44AZTTQVLJLDANCNFSM4EKCM7IQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/bhuvnesh123/FFmpeg-Video-Editor-Android/issues/12?email_source=notifications&email_token=AAEJ4IGSR2WMWAZVXJGCIRLQVN3KVA5CNFSM4EKCM7I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFBMBZY#issuecomment-558022887 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAEJ4ICDCMXGFXQ4PEYKWPLQVN3KVANCNFSM4EKCM7IQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bhuvnesh123/FFmpeg-Video-Editor-Android/issues/12?email_source=notifications&email_token=AHSLERKQ2OUEMUBNF55ZUNDQVOK2BA5CNFSM4EKCM7I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFBWWRA#issuecomment-558066500, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHSLERKWBON3Q7SSFAWCHB3QVOK2BANCNFSM4EKCM7IQ .