Tracker text changes location after toggling new tab sections

[pdehaan]

On the "fast" variation...

Steps to reproduce:

1. Be on the "fast" variation branch.
2. Visit some sites, enable the tracking, and open a new tab.
3. Look at the "Firefox blocked nn trackers and saved you nn seconds" messaging (see Figure 1 below).
4. Click the gear icon in the upper-right corner and toggle the search field (see Figure 2 below).

---

Before:

Figure 1: The "Firefox blocked nn trackers and saved you nn seconds" messaging appears below the search field.

---

Toggle:

Figure 2: Toggle the "Search" field New Tab Preference.

---

After:

Figure 3: The "Firefox blocked nn trackers and saved you nn seconds" messages appears ABOVE the search field.

[biancadanforth]

After closer inspection, I am thinking this bug is not a blocker/P1. I confirm that it is happening, but the modification stays present and visible, albeit above the search bar in the special case a user toggles it on and off. If the page is refreshed, the message returns to being below the search bar. If you open a new tab, once Kamyar's PR (PR #102 ) is merged, we will be turning off newtab preloading, and the behavior will be as below:

@pdehaan , @gregglind, what do you think?

My suspicion is that the fix for this would require some integration with Activity Stream, which may be challenging. Just thinking about the cost compared to the benefits compared to other open bugs.

[gregglind]

I claim this will not materially affect any statistics this experiment would gather, and is thus a p5, unless you happen to just figure it out.

On Sat, Feb 24, 2018 at 1:57 PM Bianca Danforth notifications@github.com wrote:

After closer inspection, I am thinking this bug is not a blocker/P1. I confirm that it is happening, but the modification stays present and visible, albeit above the search bar in the special case a user toggles it on and off. If the page is refreshed, the message returns to being below the search bar. If you open a new tab, once Kamyar's PR (PR #102 https://github.com/biancadanforth/tracking-protection-shield-study/pull/102 ) is merged, we will be turning off newtab preloading, and the behavior will be as below:

[image: tpstudy100] https://user-images.githubusercontent.com/17437436/36634459-d10f1026-1959-11e8-8120-bf91543cee58.gif

@pdehaan https://github.com/pdehaan , @gregglind https://github.com/gregglind, what do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biancadanforth/tracking-protection-shield-study/issues/100#issuecomment-368255269, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKAj2PEote0x_CMJ16e7Ug7NjNbNzuKks5tYGmrgaJpZM4SOcV3 .

[SoftVision-CarmenFat]

I also ran into a similar issue with TPM v.1.0.3, using the following steps to reproduce:

1. Install the Tracking Protection Messaging .xpi and use either "fast" or "private" variation branch.
2. Visit a website with blocked resources and then open a new tab.
3. Click the Gear button in the upper-right corner and toggle all the elements.
4. "Click Done"
5. Open a new tab and observe the tracker text.
6. Click the Gear button again and toggle all the elements.
7. Observe the tracker's text location.

Expected results:

5. The tracker text remains in the same place, above the Import option.
6. The tracker text is displayed under the search field.

Actual results:

5. The tracker text switches places with the Import option.
6. The tracker text is displayed at the bottom of the page, under the Highlights section.

This was reproducible across platforms: Windows 10 x64, macOS 10.13.3 and Ubuntu 14.04 x64.