biancadanforth / tracking-protection-shield-study

A Shield study to determine the optimal messaging, if any, for Tracking Protection in Firefox.
0 stars 3 forks source link

Closing a window does not dismiss either panel #103

Closed biancadanforth closed 6 years ago

biancadanforth commented 6 years ago

My code should be listening for a window close event to dismiss the intro and pageAction panels. This had been working prior to the memory leak fixes. What happens now is when I close a window with a panel open, the panel doesn't get properly dismissed, and when I try clicking the pageAction button on any subsequent site, it doesn't open.

Steps to reproduce:

  1. npm run firefox forcing "fast" or "private" treatment
  2. Go to a website like npr.org
  3. Notice the intro panel opens
  4. Open a new window
  5. Close the initial window
  6. Notice in the browser console, nothing is logged for the panel being dismissed
  7. Visit a website in the remaining window like nytimes.com
  8. Click the pageAction button
  9. Notice the pageAction panel does not open; this is because it is gated on the intro panel having been properly dismissed.

The same effect happens for the pageAction panel (dismiss the intro panel in step 3, open the pageAction panel and then proceed with step 4).