search

biancadanforth / tracking-protection-shield-study

A Shield study to determine the optimal messaging, if any, for Tracking Protection in Firefox.
0 stars 3 forks source link

NaN intermittently showing in `about:newtab` for total blocked ads #117

Closed biancadanforth closed 6 years ago

biancadanforth commented 6 years ago

During final UX review, jsavory found this bug.

Steps to reproduce:

  1. Run the addon, forcing "private" branch (set two prefs accordingly)
  2. Opened private window, clicked around a little bit went to a couple pages including about:home, then closed it
  3. Noticed no UI in PB mode
  4. Closed that PB window
  5. Back in the original Firefox non private window, opened a newtab page
  6. Notice the quantity for total ads on the new tab page is NaN.

I refactored the new-tab-variation.js script yesterday in PR #114 ; see if anything I changed there could be causing this. At the very least, if I can't reproduce, just add error handling so if the value is NaN or undefined, set it to 0, similar to issue #98 .

Send jsavory a XPI file Monday 3/5 morning to have her try out before the demo.