search

biancadanforth / tracking-protection-shield-study

A Shield study to determine the optimal messaging, if any, for Tracking Protection in Firefox.
0 stars 3 forks source link

Make sure units for ads/trackers are pluralized correctly #125

Closed biancadanforth closed 6 years ago

biancadanforth commented 6 years ago

I took care of this for time units in #65 , but not for ad(s) and tracker(s).

pdehaan commented 6 years ago

fast-second-singular

Figure 1: "fast" branch, with correct singular "1 second saved" string.

sfgate

Figure 2: "fast" branch, with incorrect plural "1 trackers blocked" string.

pdehaan commented 6 years ago

national_and_local_weather_radar__daily_forecast__hurricane_and_information_from_the_weather_channel_and_weather_com Figure 3: "private" branch, with incorrect plural of "1 ads blocked".

tracker-singular Figure 4: "private" branch, with incorrect plural of "1 trackers blocked".

pdehaan commented 6 years ago

new-tab-fast

I wasn't fast enough on my screenshots, but it did correctly pluralize "1 minute and 1 second" on the newtab page.

SoftVision-EmilPasca commented 6 years ago

This issue is no longer reproducible with the latest Tracking Protection Messaging .xpi installed (v.1.0.2), retested on Windows 10 x64, Mac OS 10.12 and Ubuntu 16.04 with Unbranded Beta 59.0b14.