search

biancadanforth / tracking-protection-shield-study

A Shield study to determine the optimal messaging, if any, for Tracking Protection in Firefox.
0 stars 3 forks source link

XML Parsing Error in private browsing tab #137

Closed pdehaan closed 6 years ago

pdehaan commented 6 years ago

I'm in the "private" branch (via $ npm run firefox) and when I tried going to "File > New Private Window", I get the following:

XML Parsing Error: Location: jar:file:///Users/pdehaan/dev/github/mozilla/tracking-protection-shield-study/dist/linked-addon.xpi!/content/aboutPrivateBrowsingMod.xhtml Line Number 34, Column 76:
            accesskey="&privatebrowsingpage.openPrivateWindow.accesskey;"/>
---------------------------------------------------------------------------^

https://github.com/biancadanforth/tracking-protection-shield-study/blob/fb592fb55756642a6e1c746f52afd2a30ddb6619/addon/content/aboutPrivateBrowsingMod.xhtml#L30-L34

pbmode

pdehaan commented 6 years ago

Trying to run the xhtml through a linter (https://validator.w3.org/nu/#textarea) and I'm getting a oodles of errors. I think the above error is this:

[Error:] Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag.

From line 13, column 5; to line 17, column 76

;</p>↩
   <button xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"↩
           id="startPrivateBrowsing"↩
           class="showNormal"↩
           label="&privatebrowsingpage.openPrivateWindow.label;"↩
           accesskey="&privatebrowsingpage.openPrivateWindow.accesskey;"/>↩
   <d

I think it's saying that <button> isn't a self-closing tab, and it should be <button ...></button>.

biancadanforth commented 6 years ago

I literally just copied the XHTML file for about:privatebrowsing from the my local build of Firefox, so if there are parsing errors, I am surprised!

@pdehaan , What version of Firefox are you testing on? (ex: Nightly 60, Beta 59...)? I cannot reproduce this error unfortunately. Here's what I tried:

  1. Force "private" treatment
  2. npm run firefox in unbranded Beta (Firefox 59)
  3. In the new window, click File > New Private Window
pdehaan commented 6 years ago

Nightly 60.0a1 (2018-03-05) (64-bit) on macOS via npm run firefox. I'm still seeing the bahavior in master.

biancadanforth commented 6 years ago

That's really odd, because I am seeing that it works in both Nightly and Beta on Mac OS 64 bit:

Nightly

137-nightly

Beta

137-beta

Why are we seeing different things? That's a little troubling. @rhelmer , any ideas?

pdehaan commented 6 years ago

I'm unable to repro on unbranded Firefox Beta 58.0.2 (64-bit macOS).

pdehaan commented 6 years ago

Also unable to repro on unbranded Firefox Beta 59.0b14 (64-bit macOS).

Dangerously close to just suggesting we close this if nobody else can repro. Or see if Softvision team can repro in a handful of environments.

biancadanforth commented 6 years ago

Going to close for now; I updated the TESTPLAN in PR #146 to check for this.