Prevent new tab mod from showing on other pages. Fixes #132.

biancadanforth / tracking-protection-shield-study

A Shield study to determine the optimal messaging, if any, for Tracking Protection in Firefox.

0 stars 3 forks source link

Prevent new tab mod from showing on other pages. Fixes #132. #140

Closed biancadanforth closed 6 years ago

biancadanforth commented 6 years ago

I was adding the new tab content indiscriminately, regardless if the location changed from 'about:newtab' to something else later on.

I fixed this by adding a check onLocationChange to check the location before adding new tab content.

@pdehaan : I claim this fixes the bug you were also seeing in #136 . Can you try this out and confirm?

pdehaan commented 6 years ago

So far so good. Am not seeing the new tab content being injected into mirror.co.uk, weather.com, or dictionary.com after a few page loads on each site. r+