search

biancadanforth / tracking-protection-shield-study

A Shield study to determine the optimal messaging, if any, for Tracking Protection in Firefox.
0 stars 3 forks source link

Tracking Protection Messaging panel goes blank when showing the browser window in full screen #152

Closed SoftVision-CarmenFat closed 6 years ago

SoftVision-CarmenFat commented 6 years ago

[Affected versions]:

[Affected Platforms]:

[Prerequisites]:

[Steps to reproduce]:

  1. Open the browser and navigate to a website (e.g. www.cnn.com).
  2. Click the pageAction badge for Tracking Protection Messaging in order to trigger the TPM door hanger.
  3. Press "F11" key and observe the panel.

[Expected result]:

[Actual result]:

[Notes]:

full screen tpm

biancadanforth commented 6 years ago

Thanks Carmen for noting this! I'm thinking this may not be a P1, though I'm not sure how often users go into full screen mode (and do so particularly when the pageAction panel in this study is opened)... @gregglind, what do you think about priority?

biancadanforth commented 6 years ago

I may be able to code something quickly that just dismisses the panel if the user clicks out of the window (thinking the deactivate event). Not sure if that'd do it. Worth a shot probably.

gregglind commented 6 years ago

Details wanted... which sort of full screen, and what platform? Windows or OS X?

I would call this a P2, but it’s annoying.

On Thu, Mar 8, 2018 at 12:19 PM Bianca Danforth notifications@github.com wrote:

I may be able to code something quickly that just dismisses the panel if the user clicks out of the window (thinking the deactivate event). Not sure if that'd do it. Worth a shot probably.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biancadanforth/tracking-protection-shield-study/issues/152#issuecomment-371576020, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKAj8mJed_ildun8IUkLeuH6XxzDZDIks5tcXYtgaJpZM4Si3BV .

biancadanforth commented 6 years ago

Says Windows platform and the kind of full screen you get when you press "F11".

SoftVision-EmilPasca commented 6 years ago

This issue is still reproducible with the latest Tracking Protection Messaging .xpi installed (v.1.0.2), retested on Windows 10 x64 with Unbranded Beta 59.0b14.

biancadanforth commented 6 years ago

Ah yes, I fixed it for the intro panel but not the pageAction panel. Thank you. Re-opening.

biancadanforth commented 6 years ago

I just chatted with pdol (the stakeholder on this project), and he gave me the go-ahead to simply dismiss the panels (both intro and pageAction) on window resize for all platforms. This will make this problem go away. Patch forthcoming.

SoftVision-EmilPasca commented 6 years ago

This issue is no longer reproducible with the latest Tracking Protection Messaging .xpi installed (v.1.0.5), retested on Windows 10 x64 with Unbranded Beta 59.0b14.