biancadanforth / tracking-protection-shield-study

A Shield study to determine the optimal messaging, if any, for Tracking Protection in Firefox.
0 stars 3 forks source link

A blue border is displayed when middle clicking the buttons from the panels #154

Open SoftVision-CarmenFat opened 6 years ago

SoftVision-CarmenFat commented 6 years ago

[Affected versions]:

[Affected Platforms]:

[Prerequisites]:

[Steps to reproduce]:

  1. Open the browser and navigate to a website (e.g. www.cnn.com).
  2. Click the pageAction badge for Tracking Protection Messaging in order to trigger the TPM door hanger.
  3. Press middle click on the "Disable Protection" button and observe what happen next.

[Expected result]:

[Actual result]:

[Notes]:

blue border

biancadanforth commented 6 years ago

Thanks Carmen! That's an odd behavior indeed. I could certainly look into this, but since it's not causing a functional breakage, and it uses a weird "third button" on the mouse which is unusual, I'm tempted to call this a P2 or even P3. @gregglind, could I get a second opinion here?

gregglind commented 6 years ago

Third...button... mind exploded.

I agree that this sounds like P3, but interesting!

On Thu, Mar 8, 2018 at 12:25 PM Bianca Danforth notifications@github.com wrote:

Thanks Carmen! That's an odd behavior indeed. I could certainly look into this, but since it's not causing a functional breakage, and it uses a weird "third button" on the mouse which is unusual, I'm tempted to call this a P2 or even P3. @gregglind https://github.com/gregglind, could I get a second opinion here?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biancadanforth/tracking-protection-shield-study/issues/154#issuecomment-371577783, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKAj-0dFJT34X43qM7u8BWpyfwb8EaSks5tcXeWgaJpZM4Si3CL .

gregglind commented 6 years ago

(this is hard for us to test on OSX, which doesn't support middle click.

https://www.howtogeek.com/267782/how-to-add-a-middle-click-to-your-macs-trackpad/

Curiousity: Do all fx panel buttons do this? Is this a react problem?

biancadanforth commented 6 years ago

I'm not using React or any libraries for this study. These are standard <button> HTML elements in the panel.