search

biancadanforth / tracking-protection-shield-study

A Shield study to determine the optimal messaging, if any, for Tracking Protection in Firefox.
0 stars 3 forks source link

[Windows] [Linux] The tracker text is not vertically aligned with the rest of the newtab elements #177

Closed SoftVision-CarmenFat closed 6 years ago

SoftVision-CarmenFat commented 6 years ago

[Affected versions]:

[Affected Platforms]:

[Prerequisites]:

[Steps to reproduce]:

  1. Open the browser and navigate to a website (e.g. www.cnn.com).
  2. Open a new tab and observe the tracker text.

[Expected result]:

[Actual result]:

[Notes]:

misaligned

biancadanforth commented 6 years ago

Thanks Carmen for finding this. That's a little odd. I tested it on Linux and felt I needed to add some padding and margin to get it aligned. I'll check again.

biancadanforth commented 6 years ago

Hmm... I can't reproduce this issue on Linux or Windows. I actually added padding to fix this already for #138 . You can see the before/after pictures for the Windows/Linux about:newtab in the corresponding PR, PR #158 .

For some reason, your version of Windows and Linux does not have the extra padding, whereas mine does.

Here's an example of how I see things on Windows (Linux was similar):

Now: windows177

If I revert the change from #138 : windows177without

I thought perhaps it had something to do with the fact that I was using a pseudo-element (::before) to render the SVG icon in the new tab page, but I just changed it to be a <span>, and it had no effect (PR #183 ).

I'd say it's better for this to be indented inward rather than outward if there is going to be some discrepancy. And since I can't reproduce what you're seeing, and if I fix it for you, it becomes outdented for me, I'd say I'll leave it as is as a WONTFIX.

biancadanforth commented 6 years ago

I wasn't testing on 59. Actually this was a real bug. Just fixed it. Thanks!

SoftVision-EmilPasca commented 6 years ago

This issue is no longer reproducible with the latest Tracking Protection Messaging .xpi installed (v.1.0.5), retested on Windows 10 x64, Mac OS 10.13 and Ubuntu 16.04 with Unbranded Beta 59.0b14.