search

biancadanforth / tracking-protection-shield-study

A Shield study to determine the optimal messaging, if any, for Tracking Protection in Firefox.
0 stars 3 forks source link

Tracking Protection door hanger displays on 404 pages #181

Open pdehaan opened 6 years ago

pdehaan commented 6 years ago

Steps to reproduce:

  1. Launch w/ "fast" variation.
  2. Go to a 404 page, a la "www.cbs.co".

Actual results:

The door hanger displays on a 404 page, despite having no trackers, etc.

404

biancadanforth commented 6 years ago

Thanks Peter; I'm not able to reproduce that on Unbranded Beta (still 59 since I downloaded it from a Wiki page) on Mac. Is it possible you clicked the pageAction button? Part of the intended behavior is that clicking the pageAction button, even for a page with 0 blocked resources, will trigger the intro panel if it has not yet been shown to the user.

@gregglind, what are your thoughts on priority? I am thinking a P3 since I can't reproduce, and since it doesn't break the study.

pdehaan commented 6 years ago

Yeah, I'm on an unbranded 59 Beta on macOS. And yes, I landed on the 404 page because of my stupid little fingers and inability to spell, noticed the "0s" badge in the awesomebar, and clicked it to trigger the door hanger.

unbranded59

I'd say this is P3 at best, since it doesn't break anything. I was just confused because I wasn't sure if a 404 page counted as an HTTP/S request and if the pageAction button should have been shown. But it doesn't break or change anything. Just an observation.

biancadanforth commented 6 years ago

Oh yes I see what you're saying now. It's not that the intro panel triggered on the page, but that the pageAction button was there at all (and that you could click on it to open the panel).

This is definitely an interesting edge case, since my condition for showing the button is whether or not the location of the tab is a scheme of http or https. So clearly internally Firefox is prepending the URL with one of those, even though you don't see it on the URL bar. Also Firefox is redirecting the page to the error 404 page, but that doesn't change the location. Definitely would be a problem for a permanent feature.