search

biancadanforth / tracking-protection-shield-study

A Shield study to determine the optimal messaging, if any, for Tracking Protection in Firefox.
0 stars 3 forks source link

Ensure all reason codes for ending the study are correct #31

Closed biancadanforth closed 6 years ago

biancadanforth commented 6 years ago

For example, PR #29 ends the study if TP is toggled ON or OFF. Is the ending for each scenario the most appropriate?

Basically, CMD + F all calls to endStudy and ensure the reason code is present and makes sense.

Also are there any custom reason codes that would be more helpful to send than the ShieldUtils defaults? Look at some other shield studies as examples.

Should be completed concurrently with #62 .