search

biancadanforth / tracking-protection-shield-study

A Shield study to determine the optimal messaging, if any, for Tracking Protection in Firefox.
0 stars 3 forks source link

Inconsistent results between awesomebar, dropdown, and new tab #58

Closed pdehaan closed 6 years ago

pdehaan commented 6 years ago

Steps to reproduce:

  1. Run npm run firefox.
  2. Set extensions.tracking_protection_messaging_study.variation_override flag to "fast".
  3. Reload temporary extension.
  4. Visit https://www.msn.com/en-ca/

Actual results:

msn_ca newrtab

Awesome bar says I've saved 7 seconds of my life. The dropdown menu says 0 trackers blocked and 0 seconds saved. The new tab page says 0 trackers blocked today and 0.26 minutes saved. (which is roughly 15.6 seconds).

biancadanforth commented 6 years ago

Hmmm still seeing this occur, so reopening >.>, particularly on the "fast" branch.

pdehaan commented 6 years ago

buzzfeed

I'd need to try digging through code to see if one is doing a Math.round() and another is not, or if something is doing .floor() vs .ceil().

Oddly, I'm not seeing any messaging on my about:home page in today's FF Nightly to confirm what that page says.

thechive_-_funny_pictures__photos__memes___videos_ _thechive_com

pdehaan commented 6 years ago

Note that this doesn't always happen. I see different results on the same site, so I think it's purely a rounding issue/edge case:

mirror-co-uk-dinosaurs