search

biancadanforth / tracking-protection-shield-study

A Shield study to determine the optimal messaging, if any, for Tracking Protection in Firefox.
0 stars 3 forks source link

TypeError: panel.hidePopup is not a function #68

Closed pdehaan closed 6 years ago

pdehaan commented 6 years ago

https://github.com/biancadanforth/tracking-protection-shield-study/blob/ce8f96c75659b2f46a5394689d660c2c8fc0b39b/addon/lib/Feature.jsm#L656

TypeError: panel.hidePopup is not a function      Feature.jsm:656:5

browser_console

biancadanforth commented 6 years ago

This was happening to me as well, since when you change a tab, the pageAction button in the URL bar gets removed (along with its child element, the <panel>).

I recently added a check to see if the <panel> exists in the browser.xul document before trying to remove it.

@pdehaan , I claim this was fixed in PR #67 (here is the exact line), which was merged less than 24 hours ago. Is there any chance you did not fetch the latest changes before trying this?

Let me know if you are still receiving the error. I'm not.

biancadanforth commented 6 years ago

@pdehaan , are you still seeing this issue?

biancadanforth commented 6 years ago

I'm closing this issue, as I can't reproduce the error (and I'm pretty sure I fixed it as mentioned above). Feel free to re-open or file a new issue as needed.