search

biaslab / ForneyLab.jl

Julia package for automatically generating Bayesian inference algorithms through message passing on Forney-style factor graphs.
MIT License
149 stars 33 forks source link

Nonlinear fix #181

Closed albertpod closed 3 years ago

albertpod commented 3 years ago

This PR addresses issue #166. As keyword arguments do not participate in methods dispatch, some nonlinear rules were simply ignored by ForneyLab. Together with @semihakbayrak and @ivan-bocharov, we decided to switch the keyword argument variate to the positional argument.

codecov-commenter commented 3 years ago

Codecov Report

Merging #181 (13ec0f0) into master (5d9110e) will not change coverage. The diff coverage is 37.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #181   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files          83       83           
  Lines        4061     4061           
=======================================
  Hits         3475     3475           
  Misses        586      586
Impacted Files Coverage Δ
...c/engines/julia/update_rules/nonlinear_sampling.jl 58.06% <37.50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d9110e...13ec0f0. Read the comment docs.