search

biaslab / ForneyLab.jl

Julia package for automatically generating Bayesian inference algorithms through message passing on Forney-style factor graphs.
MIT License
149 stars 35 forks source link

Incorrect outbound message update rules for GaussianMeanVariance #198

Closed bvdmitri closed 2 years ago

bvdmitri commented 2 years ago

This rule (and the one below) seems to be incorrect: https://github.com/biaslab/ForneyLab.jl/blob/dc808ac741f75b54369904e971abc0609f8c9cd7/src/engines/julia/update_rules/gaussian_mean_variance.jl#L42

See also discussion here: https://github.com/biaslab/ReactiveMP.jl/issues/96

ThijsvdLaar commented 2 years ago

Great catch, thanks a lot! Issue is fixed in #203 , will close.