search

biaslab / ForneyLab.jl

Julia package for automatically generating Bayesian inference algorithms through message passing on Forney-style factor graphs.
MIT License
149 stars 35 forks source link

Fix And node update #209

Closed ThijsvdLaar closed 2 years ago

ThijsvdLaar commented 2 years ago

This PR fixes the backward sum-product updates for the And node in the "implementing additional nodes" demo. Thanks @albertpod for catching this mistake in the derivations.

codecov-commenter commented 2 years ago

Codecov Report

Merging #209 (3a502a7) into master (005a16c) will decrease coverage by 0.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
- Coverage   87.29%   87.25%   -0.05%     
==========================================
  Files          97       97              
  Lines        4645     4645              
==========================================
- Hits         4055     4053       -2     
- Misses        590      592       +2
Impacted Files Coverage Δ
src/engines/julia/generators.jl 96.51% <0.00%> (-1.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 005a16c...3a502a7. Read the comment docs.