search

biaslab / hugo-academic-group

An academic group website theme for Hugo.
MIT License
52 stars 18 forks source link

Fixing member -vs- team #54

Closed haz closed 3 years ago

ivan-bocharov commented 3 years ago

Hi @haz

Thanks a lot for opening this PR and bringing these issues to our attention.

I have incorporated your fixes to the member page and to the index page.

Your proposal for adjusting the open_projects template seems quite reasonable, but I think that the default ordering and grouping (simply by date) is fine for the default case. We have a redesign of this page in mind with filters (and not grouping) of open positions by their type. In the meantime (while that is in the works and, unfortunately, I can't really give you an estimate) you can leverage hugo's ability for the theme users to define their own custom templates, overriding parts of the theme. We use this mechanism, for example, here.

I will now close this PR. If you have any further questions or suggestions, please let me know.

haz commented 3 years ago

Thanks! And apologies for the cascade of changes. I forgot that opening a PR would keep the commits coming as they are added. I only meant to suggest the change on member -vs- team, as some of the other changes, are indeed unique to our lab.

One note on your suggestion -- I tried and failed several times to do this, as well as add custom shortcodes, etc. Nothing worked until I realized that this line from the example site was redirecting things inappropriately. You may want to nix it entirely.

One other change that you may have skipped over on the PR: https://github.com/biaslab/hugo-academic-group/pull/54/files#diff-ba416bc0d6d5ead780412985729d46a98c1b43575978986d89881366ee4945f3R15

It's quite convenient just limiting what makes the index page based on it being "featured". As far as I could tell, that property wasn't used at all elsewhere in the code.

Cheers!

ivan-bocharov commented 3 years ago

Thanks for your notes. I will remove the layoutdir parameter from the example config. It is indeed completely unnecessary.

As for the featured flag, originally we wanted to use it for a different purpose - purely for those projects to have a higher priority when sorting. I'll consider changing the mechanism to one that you've described. Thanks for your suggestion!