search

biati-digital / glightbox

Pure Javascript lightbox with mobile support. It can handle images, videos with autoplay, inline content and iframes
MIT License
2.03k stars 228 forks source link

Remove iframe onload listener after it initialised #319

Closed Fedik closed 2 years ago

Fedik commented 2 years ago

Remove iframe onload listener after it initialized.

This is need because when ifraime contain embed page, it will trigger onload event every time User do "in-frame" navigtion. That, example, will trigger "open animation" every time when the iframe reloaded.

biati-digital commented 2 years ago

Thank you for the PR

shah commented 2 years ago

Is this already in the latest release? In my iFrames during "in-frame" navigation the lightbox reloads. Thanks to this great library!

gingerchew commented 2 years ago

@shah please create a new issue using the templates we've provided

shah commented 2 years ago

@frankie-tech I did not create a new issue because the work is already done and the code I need is in master. If I use the latest, unpinned to a version/release, code from GitHub master branch everything works (it's a great library!). My question is whether you'll be adding this code into a "release" (as opposed to "master").