search

biati-digital / nova-text-tools

Swiss Army knife for text manipulation and selection Sort, Transform, Filter, Delete Duplicates, Encode, Decode and much more...
16 stars 2 forks source link

Rename case commands according to wikipedia #16

Closed guillaumealgis closed 1 year ago

guillaumealgis commented 1 year ago

This closes https://github.com/biati-digital/nova-text-tools/issues/15

✅ Param Case should be renamed to Kebab Case ✅ Train Case as alias of the current command Header Case ✅ Screaming Snake Case as alias of the current command Constant Case ✅ Added Flatcase ✅ Added Screaming Kebab Case ✅ Added Pascal Snake Case ✅ Added camel Snake Case

For Flatcase, from what I could gather (1, 2) it should remove spaces yes (I don't think there is a definitive source of truth on this though).

I added a test for each new case.

Let me know if you think I should amend anything :)

biati-digital commented 1 year ago

Hi, thanks for the PR. I tried it and everything looks good. There was only a problem with flat case not working correctly. No case seems to work but adding delimiter causes some kind of problem. it could probably be easier to not define a delimiter and then simply remove all spaces. i'll take care of it, i need to publish the update today as i've some work that i need to focus on but again, thank you for the PR.

https://user-images.githubusercontent.com/1219228/211715586-538e855d-d09d-4d10-b537-b4d3765f6cf6.mp4

biati-digital commented 1 year ago

Found the problem, in main.js it was registered as toflatcase: 'toflatCase', but the function name is toFlatCase, just changed toflatcase: 'toFlatCase' and it's working correctly now. Thank's.

guillaumealgis commented 1 year ago

Sorry for the mistake, it slept my attention :)

Thank for the fix and for merging !