biati-digital / nova-text-tools

Swiss Army knife for text manipulation and selection Sort, Transform, Filter, Delete Duplicates, Encode, Decode and much more...
16 stars 2 forks source link

Fix conversion from Snake Case to Camel Case #17

Closed guillaumealgis closed 1 year ago

guillaumealgis commented 1 year ago

Fix a case where hello_world would be converted to helloWorldd when applying a Camel Case conversion.

(it's not actually strictly speaking related to these two naming conventions, but to the fact that the conversion removed characters (_) in the process, and the remaining space created at the end of the converted string is not "cleaned")

biati-digital commented 1 year ago

Hi, thank's for the PR, i tried but deleting a range seems to work for a single selection, when having multiple selections it fails.

https://user-images.githubusercontent.com/1219228/211721402-40a1882e-6c07-4192-ac5c-51d5190ba6dc.mp4

This is the code used as example

{
  "a_cool_snake_key": "Snake!",
  "some_other_key": 42,
  "and_another_one": "What a great example"
}
biati-digital commented 1 year ago

I've submitted an update 3.2.1, that fixes this problem, please try it and if you notice anything we can work on this PR to improve the code.

guillaumealgis commented 1 year ago

Just tested 3.2.1 quickly and this works fine for me :)

biati-digital commented 1 year ago

I'm glad it's working.