Execute getrawtransaction report error

[Jamiejoin]

class Btc():
    def connect(self):
        self.ConnRpc = BitcoinRPC(RPC_ADDRESS, RPC_PORT, RPC_USER,RPC_PASSWORD)
        self.OldConnRpc=AuthServiceProxy("http://%s:%s@%s"%(RPC_USER, RPC_PASSWORD, OLDRPC_ADDRESS))

    async def async_get_tx(self,tx):
        while True:
            raw_tx = await  self.ConnRpc.getrawtransaction(tx, True)
            break

    async def extract_block_addresses(self, block_hash):
        block = self.OldConnRpc.getblock(block_hash)
        tasks = []
        for tx in block[u'tx']:
            tasks.append(self.async_get_tx(tx))
        await asyncio.gather(*tasks)

    def get_block_address(self,block):
        add_insert = []
        while True:
            try:
                block_hash = self.OldConnRpc.getblockhash(block)
                break
            except:
                self.connect()
                print("get block error")
                sleep(1)
        self.loop.run_until_complete(self.extract_block_addresses(block_hash))

Is the error below caused by the query speed being too fast?

Traceback (most recent call last):
  File "scripthash_address.py", line 147, in <module>
    data.storage_address_scripthash()
  File "scripthash_address.py", line 131, in storage_address_scripthash
    self.get_block_address(block)
  File "scripthash_address.py", line 102, in get_block_address
    self.loop.run_until_complete(self.extract_block_addresses(block_hash))
  File "/usr/lib/python3.7/asyncio/base_events.py", line 587, in run_until_complete
    return future.result()
  File "scripthash_address.py", line 88, in extract_block_addresses
    await asyncio.gather(*tasks)
  File "scripthash_address.py", line 59, in async_get_tx
    raw_tx = await  self.ConnRpc.getrawtransaction(tx, True)
  File "/usr/local/lib/python3.7/dist-packages/bitcoinrpc/bitcoin_rpc.py", line 146, in getrawtransaction
    timeout=httpx.Timeout(timeout),
  File "/usr/local/lib/python3.7/dist-packages/bitcoinrpc/bitcoin_rpc.py", line 63, in acall
    resp = orjson.loads((await req).content)
orjson.JSONDecodeError: expected value at line 1 column 1: line 1 column 1 (char 0)

The error will stop at this txid : 103e90d89a2695f8952b513b12c705850b6b91d6ee1a9040c87d2344a3e38ff9

[bibajz]

Hello, thank you for posting the issue. I was able to reproduce the error and it seems that it comes from the default settings of httpx.AsyncClient - limits argument in the constructor is by default set to:

DEFAULT_LIMITS = Limits(max_connections=100, max_keepalive_connections=20)

Here is my devised test:

from orjson import JSONDecodeError  # Error to watch out for

rpc = bitcoinrpc.BitcoinRPC(RPC_ADDRESS, RPC_PORT, RPC_USER,RPC_PASSWORD)

async def get_raw_txs_from_block(block_hash: str, num_txs: int):
    """
    Query exactly `num_txs` from block `block_hash` concurrently.
    """
    block = await rpc.getblock(block_hash)

    tasks = []
    for i, tx_hash in enumerate(block["tx"]):
        tasks.append(rpc.getrawtransaction(tx_hash))
        if i == num_txs:
            break

    return await asyncio.gather(*tasks)

async def test_concurrent_connections_limit():
    """
    Test how many concurrent calls can the BitcoinRPC handle.
    """
    block_262250 = "00000000000000053a73327c9f7a5cffe695e7d6e66d6dca06dc70c7faea7d2d"

    for i in (2, 10, 50, 100):
        try:
            await get_raw_txs_from_block(block_262250, i)
        except JSONDecodeError:
            print(f"{i} calls concurrently is way too much!")
        else:
            print(f"{i} calls concurrently is OK!")

Running it yields the following output:

>>> await test_concurrent_connections_limit()
2 calls concurrently is OK!
10 calls concurrently is OK!
50 calls concurrently is way too much!
100 calls concurrently is way too much!

So, I will look into it during the upcoming days. My idea is to expose the creation of the httpx.AsyncClient through **kwargs in the BitcoinRPC.__init__ method.

Once again, thank you very much for pointing out the issue!

Best regards, Libor.

[bibajz]

And as a sidenote, you can query all raw transactions in one call to getblock. Just set the verbosity level to 2. :)

block_262250 = "00000000000000053a73327c9f7a5cffe695e7d6e66d6dca06dc70c7faea7d2d"

await rpc.getblock(block_262250, verbosity=2)

Libor

[Jamiejoin]

Thank you very much. I will close the question first and try it. I will reply to any results, thank you.