search

bibanon / BASC-Archiver

Python-based Imageboard (4chan) complete thread archiver.
https://pypi.python.org/pypi/BASC-Archiver/
135 stars 18 forks source link

Thumbs Regex broken on Windows, use JSON HTML Templating instead? #12

Closed antonizoon closed 9 years ago

antonizoon commented 9 years ago

Apparently the thumbs regex doesn't work on the windows version.

So when you open the HTML file, it fails to link to the internal thumbnails. However, the Image link conversion seems to work

But I think the real solution is to procedurally generate a JSON HTML templater, so we don't ever have to scrape CSS or HTML again

http://beebole.com/pure/

http://twigkit.github.io/tempo/

The question is how to load a local JSON file, since usually it's not allowed. There are some hacks here:

http://stackoverflow.com/a/18637657

DanielOaks commented 9 years ago

Thumbnails are fixed, new release pushed out.

antonizoon commented 9 years ago

Here's an explanation of what changed:

Sometime in 2015, 4chan stopped using t.4cdn.org (or even more confusingly, 0.t.4cdn.org as we had to parse from it's HTML) for thumbnail URLs in it's threads. Instead, it uses i.4cdn.org.

The BASC-Archiver was modified to support this in this commit.

However, the t.4cdn.org URL still works, for now, and t.4cdn.org is still on the 4chan API README. This is why we have left the URL alone for now on BASC-py4chan. Hopefully, they keep it that way, as it doesn't take up very much resources, and changing it would break compatiblity with Fuuka.