search

bibanon / BASC-Archiver

Python-based Imageboard (4chan) complete thread archiver.
https://pypi.python.org/pypi/BASC-Archiver/
135 stars 18 forks source link

0.9.0: --runonce doesn't work. #24

Open HASJ opened 8 years ago

HASJ commented 8 years ago

Script just keeps running. Windows version.

DanielOaks commented 8 years ago

Looks like https://github.com/bibanon/BASC-Archiver/commit/f385ae769a59afbadcd2f0a8637034356bdfb35e may have something to do with it. Thanks for the report, will look into this and release a new version if need be!

HASJ commented 8 years ago

No problem and thank YOU.

DanielOaks commented 8 years ago

Just wondering, was this closed because it's been fixed? If not, feel free to reopen it or I can create a new issue. Can take me a while to get around to things, but having an issue keeps it on my radar for when I have time to look!

HASJ commented 8 years ago

--run_once doesn't work either. I should've reported this sooner but I forgot.

DanielOaks commented 8 years ago

Alright, I do see where this issue is. I've got an initial fix over here, but I will need to modify the code with RLocks and such to make sure we don't cancel in-progress downloads (which right now, with that code, WILL HAPPEN A WHOLE LOT).

I'll keep you posted and post in here once I've fixed it properly and merged that into master.

jcook12 commented 8 years ago

Update on this fix?

DanielOaks commented 8 years ago

Just been sidetracked for a while with other stuff. I should be able to write up the last bit of this in the next day or two and push it to the branch.

On 23 January 2016 at 11:00, jcook14 notifications@github.com wrote:

Update on this fix?

— Reply to this email directly or view it on GitHub https://github.com/bibanon/BASC-Archiver/issues/24#issuecomment-174101182 .

0XE4 commented 8 years ago

Thanks @DanielOaks for your time, it will fix a really annoying bug!

DanielOaks commented 8 years ago

No problem @0XE4, thanks for your comment!

The recently released v0.9.2 should fix this issue properly. Though it may take a while after finishing the last download to actually close the program, that's something I'll be looking at very soon. (fixed by 945af237f55550699e28ac4997bb83f5aa88ca78 and in v0.9.3)

In other words: pip install --upgrade basc-archiver

Windows .exe releases are not yet updated, need to setup a new Windows environment since the laptop I could run VMs on died a while ago. Hopefully should be updated in the next day or so.