search

bibanon / BASC-py4chan

Python wrapper for 4chan API. The BA's vastly improved fork of Edgeworth's original.
http://basc-py4chan.readthedocs.org/en/latest/index.html
Do What The F*ck You Want To Public License
55 stars 13 forks source link

Fix Board object creation #19

Closed nattycleopatra closed 8 years ago

nattycleopatra commented 8 years ago

This broke with commit 5daafa9292fb5719db043f6c599cb6b58d4fcb4c changing up the variable name back in January. (Please be careful)

antonizoon commented 8 years ago

Oh dear. We'll watch out next time.

DanielOaks commented 8 years ago

Is this fix pushed into a new release? If not I can create and push a new release. Also, thanks very much for the PR and the fix!

nattycleopatra commented 8 years ago

It happened after 0.6.0 so no harm done really, but a new minor release would be cool unless it's too early.

nattycleopatra commented 8 years ago

Actually I noticed this has to be corrected other places as well, give me a minute.

DanielOaks commented 8 years ago

Yeah, we'll probably look at setting up some proper tests (and using them through Travis-CI or similar), to make sure regressions and breakages like this don't happen. And release 1.0.0 once we're happy with it, go to SemVer proper!